[ 
https://issues.apache.org/jira/browse/YARN-7050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138925#comment-16138925
 ] 

Billie Rinaldi commented on YARN-7050:
--------------------------------------

Patch 08 looks good. (The unit test failures are unrelated.) I think we should 
commit this one and complete the renaming / removal of "slider" in another 
ticket. I would also suggest some package name changes in the follow up:
* ServiceApiConstants - maybe move from 
org.apache.hadoop.yarn.service.api.constants to 
org.apache.hadoop.yarn.service.api
* ServiceMetrics - maybe move from org.apache.hadoop.yarn.service.metrics to 
org.apache.hadoop.yarn.service
* package org.apache.hadoop.yarn.service.compinstance - it might not be clear 
what "comp" is referring to, so perhaps 
org.apache.hadoop.yarn.service.component.instance would be better
* package org.apache.hadoop.yarn.service.servicemonitor - maybe change to 
org.apache.hadoop.yarn.service.monitor

> Post cleanup after YARN-6903
> ----------------------------
>
>                 Key: YARN-7050
>                 URL: https://issues.apache.org/jira/browse/YARN-7050
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Jian He
>            Assignee: Jian He
>         Attachments: YARN-7050.yarn-native-services.01.patch, 
> YARN-7050.yarn-native-services.02.patch, 
> YARN-7050.yarn-native-services.03.patch, 
> YARN-7050.yarn-native-services.04.patch, 
> YARN-7050.yarn-native-services.05.patch, 
> YARN-7050.yarn-native-services.06.patch, 
> YARN-7050.yarn-native-services.07.patch, 
> YARN-7050.yarn-native-services.08.patch
>
>
> This jira tries to remove some old code, and moves dependency classes to the 
> new package, and also some other side changes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to