[
https://issues.apache.org/jira/browse/YARN-6612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16140813#comment-16140813
]
Daniel Templeton commented on YARN-6612:
----------------------------------------
Thanks, [~yufeigu].
bq. Would it be easier to understand if changing {{calculateShares()}} to
{{calculateShareUsages()}}?
Not really? Maybe I'm missing your point.
bq. What if weight is 0?
Interesting point! Not a new issue, though. I'll have a look to see why it's
never bitten us so far and whether we should fix it here.
bq. It doesn't need weight while calculating min share.
Also not a new issue. That's the way it was calculated before. Yeah, it looks
wrong to me, too. [~kasha], any insights?
bq. Would it make more sense if we sort it by dominant min share which is
minShare/cluster?
Also not a new issue. I'm just trying to preserve the existing semantics.
I'll address the other issues and the unit tests in a new patch shortly.
> Update fair scheduler policies to be aware of resource types
> ------------------------------------------------------------
>
> Key: YARN-6612
> URL: https://issues.apache.org/jira/browse/YARN-6612
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: fairscheduler
> Affects Versions: YARN-3926
> Reporter: Daniel Templeton
> Assignee: Daniel Templeton
> Attachments: YARN-6612.YARN-3926.001.patch,
> YARN-6612.YARN-3926.002.patch, YARN-6612.YARN-3926.004.patch,
> YARN-6612.YARN-3926.005.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
