[
https://issues.apache.org/jira/browse/YARN-6612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159530#comment-16159530
]
Yufei Gu commented on YARN-6612:
--------------------------------
Looks good to me generally. Some nits:
# Nobody use {{public ResourceWeights(float memoryWeight, float cpuWeight)}},
we could either remove it or remove the whole class as we discussed before. I
am OK if we put this into followup JIRAs.
# The following Java doc should be "1 for fair shares, 2 is for min shares".
{code}
* @param index the outer index of the shares arrays to compare. 0 is for
* fair shares, and 1 is for min shares
{code}
> Update fair scheduler policies to be aware of resource types
> ------------------------------------------------------------
>
> Key: YARN-6612
> URL: https://issues.apache.org/jira/browse/YARN-6612
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: fairscheduler
> Affects Versions: YARN-3926
> Reporter: Daniel Templeton
> Assignee: Daniel Templeton
> Attachments: YARN-6612.YARN-3926.001.patch,
> YARN-6612.YARN-3926.002.patch, YARN-6612.YARN-3926.004.patch,
> YARN-6612.YARN-3926.005.patch, YARN-6612.YARN-3926.006.patch,
> YARN-6612.YARN-3926.007.patch, YARN-6612.YARN-3926.008.patch,
> YARN-6612.YARN-3926.009.patch, YARN-6612.YARN-3926.010.patch,
> YARN-6612.YARN-3926.011.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
