[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144207#comment-16144207
]
Wangda Tan commented on YARN-6623:
----------------------------------
Thanks [~vvasudev],
Apologize for the delays. I haven't done any detailed reviews yet, I will leave
detailed reviews to other folks due to my availability.
Just one quick comment: for feature enable/disable. I suggest to put under
section.
For GPU feature (YARN-6852), I made config like:
{code}
[gpu]
# Enable / disable the module
module.enabled=true/false
{code}
If you're OK with the style, I suggest to make it consistent: You can use
{{module-configs.h}} to call {{module_enabled}} and get the config.
And what is feature {{tc}}? Could you make the feature name more descriptive?
> Add support to turn off launching privileged containers in the
> container-executor
> ---------------------------------------------------------------------------------
>
> Key: YARN-6623
> URL: https://issues.apache.org/jira/browse/YARN-6623
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Reporter: Varun Vasudev
> Assignee: Varun Vasudev
> Priority: Blocker
> Attachments: YARN-6623.001.patch, YARN-6623.002.patch,
> YARN-6623.003.patch, YARN-6623.004.patch, YARN-6623.005.patch,
> YARN-6623.006.patch
>
>
> Currently, launching privileged containers is controlled by the NM. We should
> add a flag to the container-executor.cfg allowing admins to disable launching
> privileged containers at the container-executor level.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
