[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16155591#comment-16155591
]
Eric Badger commented on YARN-6623:
-----------------------------------
{{git apply}} is failing for me on DockerClient.java. It looks like it doesn't
do fuzzing like patch does. Not sure if we need to fix that or not.
Additionally, the code doesn't compile for me on my rhel 6.8 VM. It looks like
it's complaining about the C99 syntax that [[email protected]]
mentioned
[here|https://issues.apache.org/jira/browse/YARN-6033?focusedCommentId=16111913&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16111913].
{noformat}
[WARNING] /usr/bin/c++
-I/home/ebadger/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src
-I/home/ebadger/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/target/native
-isystem
/home/ebadger/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/../../../../../hadoop-common-project/hadoop-common/src/main/native/gtest/include
-I/home/ebadger/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor
-I/home/ebadger/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl
-fstack-check -g -O2 -Wall -pthread -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE
-o
CMakeFiles/cetest.dir/main/native/container-executor/test/utils/test_docker_util.cc.o
-c
/home/ebadger/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/test/utils/test_docker_util.cc
[WARNING] make[2]: Leaving directory
`/home/ebadger/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/target/native'
[WARNING] make[1]: Leaving directory
`/home/ebadger/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/target/native'
[WARNING] In file included from
/home/ebadger/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/test/utils/test_docker_util.cc:24:
[WARNING]
/home/ebadger/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/utils/docker-util.c:
In function ‘int get_docker_command(const char*, const configuration*, char*,
size_t)’:
[WARNING]
/home/ebadger/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/utils/docker-util.c:234:
error: expected primary-expression before ‘.’ token
[WARNING]
/home/ebadger/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/utils/docker-util.c:234:
error: expected primary-expression before ‘.’ token
[WARNING]
/home/ebadger/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/utils/docker-util.c:
In function ‘int get_docker_inspect_command(const char*, const configuration*,
char*, size_t)’:
[WARNING]
/home/ebadger/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/utils/docker-util.c:264:
error: expected primary-expression before ‘.’ token
[WARNING]
/home/ebadger/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/utils/docker-util.c:264:
error: expected primary-expression before ‘.’ token
[WARNING]
/home/ebadger/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/utils/docker-util.c:
In function ‘int get_docker_load_command(const char*, const configuration*,
char*, size_t)’:
[WARNING]
/home/ebadger/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/utils/docker-util.c:316:
error: expected primary-expression before ‘.’ token
[WARNING]
/home/ebadger/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/utils/docker-util.c:316:
error: expected primary-expression before ‘.’ token
[WARNING]
/home/ebadger/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/utils/docker-util.c:
In function ‘int get_docker_pull_command(const char*, const configuration*,
char*, size_t)’:
[WARNING]
/home/ebadger/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/utils/docker-util.c:360:
error: expected primary-expression before ‘.’ token
[WARNING]
/home/ebadger/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/utils/docker-util.c:360:
error: expected primary-expression before ‘.’ token
[WARNING]
/home/ebadger/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/utils/docker-util.c:
In function ‘int get_docker_rm_command(const char*, const configuration*,
char*, size_t)’:
[WARNING]
/home/ebadger/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/utils/docker-util.c:399:
error: expected primary-expression before ‘.’ token
[WARNING]
/home/ebadger/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/utils/docker-util.c:399:
error: expected primary-expression before ‘.’ token
[WARNING]
/home/ebadger/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/utils/docker-util.c:
In function ‘int get_docker_stop_command(const char*, const configuration*,
char*, size_t)’:
[WARNING]
/home/ebadger/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/utils/docker-util.c:440:
error: expected primary-expression before ‘.’ token
[WARNING]
/home/ebadger/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/utils/docker-util.c:440:
error: expected primary-expression before ‘.’ token
[WARNING]
/home/ebadger/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/utils/docker-util.c:
In function ‘int get_docker_run_command(const char*, const configuration*,
char*, size_t)’:
[WARNING]
/home/ebadger/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/utils/docker-util.c:814:
error: expected primary-expression before ‘.’ token
[WARNING]
/home/ebadger/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/utils/docker-util.c:814:
error: expected primary-expression before ‘.’ token
[WARNING]
/home/ebadger/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/test/utils/test_docker_util.cc:
In member function ‘virtual void
ContainerExecutor::TestDockerUtil_test_docker_config_param_Test::TestBody()’:
[WARNING]
/home/ebadger/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/test/utils/test_docker_util.cc:1057:
error: expected primary-expression before ‘.’ token
{noformat}
The error is around the struct initialization {noformat} struct configuration
command_config = {.size=0, .sections=NULL}; {noformat}
> Add support to turn off launching privileged containers in the
> container-executor
> ---------------------------------------------------------------------------------
>
> Key: YARN-6623
> URL: https://issues.apache.org/jira/browse/YARN-6623
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Reporter: Varun Vasudev
> Assignee: Varun Vasudev
> Priority: Blocker
> Attachments: YARN-6623.001.patch, YARN-6623.002.patch,
> YARN-6623.003.patch, YARN-6623.004.patch, YARN-6623.005.patch,
> YARN-6623.006.patch, YARN-6623.007.patch, YARN-6623.008.patch
>
>
> Currently, launching privileged containers is controlled by the NM. We should
> add a flag to the container-executor.cfg allowing admins to disable launching
> privileged containers at the container-executor level.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
