[
https://issues.apache.org/jira/browse/YARN-7095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16148001#comment-16148001
]
Subru Krishnan commented on YARN-7095:
--------------------------------------
Thanks [~giovanni.fumarola] for the patch. I looked at it and have a few minor
comments, all in {{FederationInterceptorREST}}:
# Use {{HadoopExecutors}} to instantiate the {{ExecutorCompletionService}} so
that we have proper logging on failures.
# Wherever you are using *executors*, please have a finally with
shutdown/cleanup.
# In *getNodes*, _deleteDuplicateNodesInfo_ is both redundant and inefficient.
Simply collect the response in a set and add to {{NodesInfo}}.
(1) & (2) are also applicable for *getApps* (YARN-7010).
> Federation: routing REST invocations transparently to multiple RMs (part 3 -
> getNodes)
> --------------------------------------------------------------------------------------
>
> Key: YARN-7095
> URL: https://issues.apache.org/jira/browse/YARN-7095
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Giovanni Matteo Fumarola
> Assignee: Giovanni Matteo Fumarola
> Attachments: YARN-7095.v1-rebase.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
