[ https://issues.apache.org/jira/browse/YARN-7095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16149419#comment-16149419 ]
Subru Krishnan commented on YARN-7095: -------------------------------------- [~giovanni.fumarola], I looked at the latest patch; it's not just about the simple merge tests, you have a good tests covering combination of good and bad SubClusters etc which are not covered in {{TestRouterWebServiceUtil}}. You should follow the pattern from {{TestInMemoryPlan::doAssertions}} and {{TestInMemoryPlan::checkAllocation}}. > Federation: routing REST invocations transparently to multiple RMs (part 3 - > getNodes) > -------------------------------------------------------------------------------------- > > Key: YARN-7095 > URL: https://issues.apache.org/jira/browse/YARN-7095 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Giovanni Matteo Fumarola > Assignee: Giovanni Matteo Fumarola > Attachments: YARN-7095.v1-rebase.patch, YARN-7095.v2.patch, > YARN-7095.v3.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org