[
https://issues.apache.org/jira/browse/YARN-6600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153255#comment-16153255
]
Sunil G commented on YARN-6600:
-------------------------------
Some minor:
# In {{yarn.scheduler.capacity.root.default.maximum-application-lifetime}} and
{{yarn.scheduler.capacity.root.default.default-application-lifetime}}, default
value is -1. But could be configured as 0 also, is that invalid ?
# Current configuration enforces admin to configure
{{maximum-application-lifetime}}, even though admin just need
{{default-application-lifetime}}. Is it possible that admin might not know how
much max some special app may run?
# below code
{code}
2589 if (lifetimeRequestedByApp <= 0) {
2590 return defaultApplicationLifetime;
2591 } else if (lifetimeRequestedByApp > maximumApplicationLifetime) {
2592 return ((LeafQueue) queue).getMaximumApplicationLifetime();
2593 }
{code}
we could return with {{maximumApplicationLifetime}} in *else..if*
# below code
{code}
591 // always send Long#MAX_VALUE to get queue maximum lifetime
value!
592 long queueMaxLifetimeInSec =
593 scheduler.checkAndGetApplicationLifetime(app.getQueue(),
Long.MAX_VALUE);
{code}
If {{maximumApplicationLifetime}} is not configured, we ll get Long.MAX_VALUE
for *queueMaxLifetimeInSec*.
# {{updatedlifetimeInMills}} -> {{updatedlifetimeInMillis}}
# Typo in LeafQueue , *can't*
{code}
248 if (defaultLifetime > maxLifetime) {
249 throw new YarnRuntimeException("Default lifetime" +
defaultLifetime
250 + " cann't exceed maximum lifetime " + maxLifetime);
251 }
{code}
# In CapacityScheduler.md, please mention this is only for LeafQueue and wont
inherit from parent.
> Enhance default lifetime of application at LeafQueue level.
> -----------------------------------------------------------
>
> Key: YARN-6600
> URL: https://issues.apache.org/jira/browse/YARN-6600
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacity scheduler
> Reporter: Rohith Sharma K S
> Assignee: Rohith Sharma K S
> Attachments: YARN-6600.01.patch, YARN-6600.02.patch, [YARN-6600]
> Extend lifetime to scheduler Leaf Queue.pdf
>
>
> Setting timeout at LeafQueue level allows admin to control from bad apps
> which uses most of the resources for all the time.
> Example : Any application submitted to particular queue i.e QUEUE-1 should
> not run more than N hours. Even user set lifetime as N+1 hour, the
> application will be killed after N hours.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
