[ 
https://issues.apache.org/jira/browse/YARN-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154031#comment-16154031
 ] 

Shane Kumpf commented on YARN-4759:
-----------------------------------

[~ebadger] - There are two reasons why it would be good to continue using 
{{docker stop}}/{{docker kill}}. Dockerfile supports the STOPSIGNAL directive. 
If a particular signal is needed to gracefully stop the process, the user can 
define the signal via the Dockerfile that is sent when {{docker stop}} is 
called. The second scenario is for very short lived containers. In my 
experience, ~3 seconds is the lower bound for starting up a container. During 
that time the PID may not be available via {{docker inspect}}, so pid based 
signalling breaks down and may leave "leaked" running containers. We need to 
use {{docker stop}} in that case. I agree that we need to improve the exception 
handling and I will pursue that.

> Fix signal handling for docker containers
> -----------------------------------------
>
>                 Key: YARN-4759
>                 URL: https://issues.apache.org/jira/browse/YARN-4759
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: yarn
>            Reporter: Sidharta Seethana
>            Assignee: Shane Kumpf
>             Fix For: 2.9.0, 3.0.0-alpha1
>
>         Attachments: YARN-4759.001.patch, YARN-4759.002.patch, 
> YARN-4759.003.patch
>
>
> The current signal handling (in the DockerContainerRuntime) needs to be 
> revisited for docker containers. For example, container reacquisition on NM 
> restart might not work, depending on which user the process in the container 
> runs as. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to