[
https://issues.apache.org/jira/browse/YARN-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157776#comment-16157776
]
Eric Badger commented on YARN-4759:
-----------------------------------
bq. There are two reasons why it would be good to continue using docker
stop/docker kill. Dockerfile supports the STOPSIGNAL directive. If a particular
signal is needed to gracefully stop the process, the user can define the signal
via the Dockerfile that is sent when docker stop is called.
I thought that you had decided that we didn't need to worry about this in your
[comment|https://issues.apache.org/jira/browse/YARN-4759?focusedCommentId=15241924&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15241924]
above?
bq. During that time the PID may not be available via docker inspect, so pid
based signalling breaks down and may leave "leaked" running containers. We need
to use docker stop in that case
How does {{docker stop}} solve the issue here? If the container doesn't exist
yet, then docker stop will fail with "No such container" and stop trying. The
documentation isn't very informative, but it doesn't appear to wait the grace
period for the SIGKILL if it can't find the container in the first place.
> Fix signal handling for docker containers
> -----------------------------------------
>
> Key: YARN-4759
> URL: https://issues.apache.org/jira/browse/YARN-4759
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn
> Reporter: Sidharta Seethana
> Assignee: Shane Kumpf
> Fix For: 2.9.0, 3.0.0-alpha1
>
> Attachments: YARN-4759.001.patch, YARN-4759.002.patch,
> YARN-4759.003.patch
>
>
> The current signal handling (in the DockerContainerRuntime) needs to be
> revisited for docker containers. For example, container reacquisition on NM
> restart might not work, depending on which user the process in the container
> runs as.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
