[
https://issues.apache.org/jira/browse/YARN-6612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163715#comment-16163715
]
Yufei Gu commented on YARN-6612:
--------------------------------
Thanks for removing the class ResourceWeight. Looks good to me generally. Some
nits:
- We probably want to remove FSAppAttempt#getResourceWeights,
FSAppAttempt#weight since not only they are not used, but also they could be
confused with FSAppAttempt#getWeight();
- Is it a good practice to create a constant for weight 1.0f?
> Update fair scheduler policies to be aware of resource types
> ------------------------------------------------------------
>
> Key: YARN-6612
> URL: https://issues.apache.org/jira/browse/YARN-6612
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: fairscheduler
> Affects Versions: YARN-3926
> Reporter: Daniel Templeton
> Assignee: Daniel Templeton
> Attachments: YARN-6612.015.patch, YARN-6612.YARN-3926.001.patch,
> YARN-6612.YARN-3926.002.patch, YARN-6612.YARN-3926.004.patch,
> YARN-6612.YARN-3926.005.patch, YARN-6612.YARN-3926.006.patch,
> YARN-6612.YARN-3926.007.patch, YARN-6612.YARN-3926.008.patch,
> YARN-6612.YARN-3926.009.patch, YARN-6612.YARN-3926.010.patch,
> YARN-6612.YARN-3926.011.patch, YARN-6612.YARN-3926.012.patch,
> YARN-6612.YARN-3926.013.patch, YARN-6612.YARN-3926.014.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
