[ 
https://issues.apache.org/jira/browse/YARN-7174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166745#comment-16166745
 ] 

Xuan Gong commented on YARN-7174:
---------------------------------

Thanks for the review. [~djp]

bq. Looks like we remove the verification of output of yarn log cli usage. Any 
special reason to do this? If not, we should add it back to prevent 
careless/unexpected change of usage output.

Make sense. Add them back

bq. Sounds like we were defining the default max retries and retry intervals 
inline code, but better separated it out - may be too heavy to define in 
YarnConfiguration but at least define it in front of class.

DONE.

bq. After adding two options to log CLI, we should add documentation change in 
yarn log CLI page 

Looks like that we missed many more options for log cli. Let us do it 
separately.  https://issues.apache.org/jira/browse/YARN-7195

> Add retry logic in LogsCLI when fetch running application logs
> --------------------------------------------------------------
>
>                 Key: YARN-7174
>                 URL: https://issues.apache.org/jira/browse/YARN-7174
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>         Attachments: YARN-7174.1.patch, YARN-7174.2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to