[ 
https://issues.apache.org/jira/browse/YARN-7174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166895#comment-16166895
 ] 

Junping Du commented on YARN-7174:
----------------------------------

Thanks [~xgong] for updating the patch. The patch looks good to me in overall. 
Just one small issue:

-- Looks like we remove the verification of output of yarn log cli usage. Any 
special reason to do this? If not, we should add it back to prevent 
careless/unexpected change of usage output.
---- Make sense. Add them back.
I think we haven't addressed this comment in v2 patch?

> Add retry logic in LogsCLI when fetch running application logs
> --------------------------------------------------------------
>
>                 Key: YARN-7174
>                 URL: https://issues.apache.org/jira/browse/YARN-7174
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>         Attachments: YARN-7174.1.patch, YARN-7174.2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to