[
https://issues.apache.org/jira/browse/YARN-7241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179520#comment-16179520
]
Jonathan Hung commented on YARN-7241:
-------------------------------------
Thanks for the feedback [~leftnoteasy] - most of these changes make sense to
me, had a few concerns:
bq. for CLI: schedconf => scheduler-conf
How about schedulerconf? For consistency with the other yarn cmds
bq. It looks like we may not need to add anything to
CapacitySchedulerConfiguration. CS_CONF_PROVIDER can be replaced by
SCHEDULER_CONFIGURATION_STORE_CLASS, correct?
Not sure about this, currently CS_CONF_PROVIDER used for enabling the feature
(file vs API), then SCHEDULER_CONFIGURATION_STORE_CLASS for the store
implementation. I suppose we could do something like: if
SCHEDULER_CONFIGURATION_STORE_CLASS is null, then use file based conf provider,
else use store-based conf provider. What do you think?
bq. "Memory" should not be a default option value, we should put "zk" as
default. (Need to change CapacityScheduler.md)
Currently default implementation of RMStateStore is also memory. Also if they
enable this feature and it defaults to zk, startup will fail since they also
need to configure other zookeeper related configs. Not sure if this is the
behavior we want. To me it makes sense to default to a naive (memory)
implementation, and if they have specific requirements (i.e. RM HA) then they
can configure it to use zk. What do you think?
> Merge YARN-5734 to trunk/branch-2
> ---------------------------------
>
> Key: YARN-7241
> URL: https://issues.apache.org/jira/browse/YARN-7241
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Jonathan Hung
> Assignee: Jonathan Hung
> Attachments: YARN-7241.001.patch
>
>
> Ticket for jenkins pre-commit for full diff.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
