[
https://issues.apache.org/jira/browse/YARN-7241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181531#comment-16181531
]
Wangda Tan commented on YARN-7241:
----------------------------------
[~jhung],
I'm doing another scan of the aggregated patch, some additional comments:
1) For REST API: It should be either {{lower-cases-connected-by-hypen}} or
camelCase. Existing REST API is mixed: Could you clean up this to make sure
it's consistent?
2) For configuration:
The latest patch (003) still requires admin to update two places in order to
use the feature:
a. In capacity-scheduler.xml: set CS_CONF_PROVIDER to store
b. In yarn-site.xml: set a bunch of configs including
SCHEDULER_CONFIGURATION_STORE_CLASS.
In this case, how about adding a new acceptable value "config-file" to
SCHEDULER_CONFIGURATION_STORE_CLASS? This will be default value as well. And
(mutable) scheduler will load this config and decide which store class to use.
3) CapacityScheduler.md:
- Under " Changing Queue Configuration": add a small paragraph at the
beginning of the section describes what's the config store options (config-file
/ zk / leveldb), which config store is default, etc.
- Under "Changing queue configuration via API": please note this is an alpha
feature which is subject to change.
4) ResourceManagerRest.md
- Also, please add a note to mention this is an alpha feature and subject to
change.
> Merge YARN-5734 to trunk/branch-2
> ---------------------------------
>
> Key: YARN-7241
> URL: https://issues.apache.org/jira/browse/YARN-7241
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Jonathan Hung
> Assignee: Jonathan Hung
> Attachments: YARN-7241.001.patch, YARN-7241.002.patch,
> YARN-7241.003.patch
>
>
> Ticket for jenkins pre-commit for full diff.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
