[
https://issues.apache.org/jira/browse/YARN-7246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16193124#comment-16193124
]
Jason Lowe commented on YARN-7246:
----------------------------------
Sorry to show up late here. Patch looks mostly OK, but it would be nice to fix
the inconsistent memory handling in the get_docker_binary_path. As it is now,
it _sometimes_ returns a path that was malloc'd, and the caller doesn't know
whether or not to free it. It should either always require freeing by the
caller or never. Otherwise someone could come along later and see how
docker_binary is treated inconsistently from the other variables and decide to
"fix" it. A simple way to fix it is to have it {{strdup}} the built-in string
when it didn't get one from the conf, then the caller can always free the
result.
> Fix the default docker binary path
> ----------------------------------
>
> Key: YARN-7246
> URL: https://issues.apache.org/jira/browse/YARN-7246
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Reporter: Shane Kumpf
> Assignee: Shane Kumpf
> Priority: Blocker
> Attachments: YARN-7246-branch-2.8.2.001.patch,
> YARN-7246-branch-2.8.2.002.patch, YARN-7246-branch-2.8.2.003.patch,
> YARN-7246-branch-2.8.2.004.patch, YARN-7246-branch-2.8.2.005.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
