[
https://issues.apache.org/jira/browse/YARN-7246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16197142#comment-16197142
]
Jason Lowe commented on YARN-7246:
----------------------------------
Thanks for updating the patch!
I thought at first that there was a missing free call for docker_binary_user in
the test, but then I realized adding that would result in a double-free. That
tells me that the calling convention for get_docker_binary_path is still
confusing. It's only correct to call it if we pass _and forget_ the result of
getting the config path. It would be safer and more consistent if
get_docker_binary_path did the conf key lookup directly rather than relying on
the caller to do so and also know the intricacies of memory management wrt. the
arg that is passed.
In test-container-executor the new tests are using {{strncmp}} which is
incorrect. The test will pass if the result being tested is a much longer
string where the expected result happens to be a prefix. The tests should just
be using {{strcmp}}.
> Fix the default docker binary path
> ----------------------------------
>
> Key: YARN-7246
> URL: https://issues.apache.org/jira/browse/YARN-7246
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Reporter: Shane Kumpf
> Assignee: Shane Kumpf
> Priority: Blocker
> Attachments: YARN-7246-branch-2.8.2.001.patch,
> YARN-7246-branch-2.8.2.002.patch, YARN-7246-branch-2.8.2.003.patch,
> YARN-7246-branch-2.8.2.004.patch, YARN-7246-branch-2.8.2.005.patch,
> YARN-7246-branch-2.8.2.006.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
