[
https://issues.apache.org/jira/browse/YARN-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198077#comment-16198077
]
Arun Suresh commented on YARN-4511:
-----------------------------------
[~haibochen], took a quick look at the patch.
With regard to the changes to the {{swapContainer}} method, the original
intent, was as you guessed to swap the internal container objects of two
RMContainers. Generally, in the context of container updates, the new container
is killed off immediately after the swap. We assume this swap happens somewhat
transitionally (given the locking order etc.), and allows us to side-step
having to deal with intermediate events the original RMContainer might have to
deal with during the update. Also, in the context of container updates,
generally, the a container stays on the same node - so was surprised that you
added a newNode and oldNode arguments to the method, since I felt it does not
make sense. Maybe if you could point me to how you are going to ultimately use
the changes - I might have more context ?
> Common scheduler changes supporting scheduler-specific implementations
> ----------------------------------------------------------------------
>
> Key: YARN-4511
> URL: https://issues.apache.org/jira/browse/YARN-4511
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Wangda Tan
> Assignee: Haibo Chen
> Attachments: YARN-4511-YARN-1011.00.patch,
> YARN-4511-YARN-1011.01.patch, YARN-4511-YARN-1011.02.patch,
> YARN-4511-YARN-1011.03.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
