[
https://issues.apache.org/jira/browse/YARN-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16206297#comment-16206297
]
Wangda Tan commented on YARN-4511:
----------------------------------
Thanks [~haibo.chen] for the explanation.
bq. I am thinking of decoupling allocationInThisHeart from node heartbeat by
renaming it to resourcesOfContainersPendingLaunch and update it in
containerStarted()
method instead of resetting every node heartbeat. Let me know what you think.
Sounds good to me.
bq. The launchedContainer should probably be renamed to allocatedContainer and
launchedOnNode is to track whether the allocated
container is actually launched on the node. This piece code already exists. I
can do the renaming if you are fine with it.
+1 to rename it now.
bq. Very much for the same reason you are thinking of here, I am more inclined
to keep OverAllocationInfo for now. I am not sure if we just have
ResourceThresholds,
how we can keep backward compatibility in a clean way if we ever want to
include more for NM overallocation configs. I agree we should do the
consolidating
with resource profiles before the release, I think we can revisit this topic
then.
Make sense if we can have a clean API/proto change before release.
> Common scheduler changes supporting scheduler-specific implementations
> ----------------------------------------------------------------------
>
> Key: YARN-4511
> URL: https://issues.apache.org/jira/browse/YARN-4511
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Wangda Tan
> Assignee: Haibo Chen
> Attachments: YARN-4511-YARN-1011.00.patch,
> YARN-4511-YARN-1011.01.patch, YARN-4511-YARN-1011.02.patch,
> YARN-4511-YARN-1011.03.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
