[
https://issues.apache.org/jira/browse/YARN-6608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16201437#comment-16201437
]
Wangda Tan commented on YARN-6608:
----------------------------------
[~curino], my pleasure.
1) For test case:
Most test cases are failed with error:
{code}
org/eclipse/jetty/server/Handler : Unsupported major.minor version 52.0
{code}
This is caused by jetty 9.3+ dependencies added to SLS:
https://dev.eclipse.org/mhonarc/lists/jetty-announce/msg00080.html which only
support JDK 8, but in branch-2 it should support both of JDK 7/8.
Reverted this part of change and after that all test cases pass in my local
environment except:
TestDebugOverflowUserlimit
This test looks problematic, which failed with error:
{code}
...
java.io.FileNotFoundException: File src/test/resources/overflow.json does not
exist
{code}
And the {{TestDebugOverflowUserlimit}} is not existed in trunk, is this file
added by mistake? I removed the file from the patch. [~curino], any suggestions
here?
2) For javac warning:
Hopefully this patch could fix this problem.
3) For shellcheck:
The warning exists in trunk as well. Filed YARN-7318 to track the problem
separately.
In general: unit test is not a problem since I can run it locally without any
issue. If javac turns to green, I suggest to commit this patch and fix the
shell check on the separate JIRA.
Attached ver.6 patch.
> Backport all SLS improvements from trunk to branch-2
> ----------------------------------------------------
>
> Key: YARN-6608
> URL: https://issues.apache.org/jira/browse/YARN-6608
> Project: Hadoop YARN
> Issue Type: Improvement
> Affects Versions: 2.9.0
> Reporter: Carlo Curino
> Assignee: Carlo Curino
> Attachments: YARN-6608-branch-2.v0.patch,
> YARN-6608-branch-2.v1.patch, YARN-6608-branch-2.v2.patch,
> YARN-6608-branch-2.v3.patch, YARN-6608-branch-2.v4.patch,
> YARN-6608-branch-2.v5.patch, YARN-6608-branch-2.v6.patch
>
>
> The SLS has received lots of attention in trunk, but only some of it made it
> back to branch-2. This patch is a "raw" fork-lift of the trunk development
> from hadoop-tools/hadoop-sls.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
