[
https://issues.apache.org/jira/browse/YARN-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211480#comment-16211480
]
Miklos Szegedi commented on YARN-4511:
--------------------------------------
Thank you, [~haibochen] for the patch. I have a few comments.
{code}
112 public synchronized void updateTotalResource(Resource resource){
{code}
I think we need to clone resource before assigning.
{code}
308 public RMContainer swapContainer(RMContainer tempRMContainer,
{code}
The two node updates should be atomic, and I would release the resources first
and assign second.
{code}
177 allocatedContainers.put(
178 container.getId(),
179 new ContainerInfo(rmContainer, launchedOnNode));
{code}
I think this can be pulled outside the if.
{code}
203 public synchronized void guaranteedContainerResourceAllocated(
{code}
It might be helpful, to throw if the unallocated resource is less than the
request.
{code}
419 getNumOpportunisticContainers()+ " available=" +
{code}
There is a missing space, also we mention containers in the row above instead
of guaranteed containers.
> Common scheduler changes supporting scheduler-specific implementations
> ----------------------------------------------------------------------
>
> Key: YARN-4511
> URL: https://issues.apache.org/jira/browse/YARN-4511
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Wangda Tan
> Assignee: Haibo Chen
> Attachments: YARN-4511-YARN-1011.00.patch,
> YARN-4511-YARN-1011.01.patch, YARN-4511-YARN-1011.02.patch,
> YARN-4511-YARN-1011.03.patch, YARN-4511-YARN-1011.04.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
