[ 
https://issues.apache.org/jira/browse/YARN-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215566#comment-16215566
 ] 

Miklos Szegedi commented on YARN-4511:
--------------------------------------

Thank you, [~haibochen] for the patch.
{code}
342         // notify schedulerNode of the update to correct resource accounting
343         node.containerUpdated(existingRMContainer, existingContainer);
344     
345         
((RMContainerImpl)tempRMContainer).setContainer(updatedTempContainer);
346         // notify SchedulerNode of the update to correct resource accounting
347         node.containerUpdated(tempRMContainer, tempContainer);
{code}
I think these still need to be atomic from the perspective of the node. It may 
happen that there is an allocation decision before the release and after 
reacquiring the resources here. This may lead to double allocation of the same 
resources on the node.


> Common scheduler changes supporting scheduler-specific implementations
> ----------------------------------------------------------------------
>
>                 Key: YARN-4511
>                 URL: https://issues.apache.org/jira/browse/YARN-4511
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Wangda Tan
>            Assignee: Haibo Chen
>         Attachments: YARN-4511-YARN-1011.00.patch, 
> YARN-4511-YARN-1011.01.patch, YARN-4511-YARN-1011.02.patch, 
> YARN-4511-YARN-1011.03.patch, YARN-4511-YARN-1011.04.patch, 
> YARN-4511-YARN-1011.05.patch, YARN-4511-YARN-1011.06.patch, 
> YARN-4511-YARN-1011.07.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to