[
https://issues.apache.org/jira/browse/YARN-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217700#comment-16217700
]
Jason Lowe commented on YARN-4511:
----------------------------------
bq. I can the patch up if we are willing to check in the rest of the patch even
though the change causes new unit test failures. Thoughts?
Apologies for showing up late. I've not been following this JIRA that closely,
but I did see this go by and it raised alarms. We should *never* check in code
that knowingly breaks unit tests. It is quite disruptive to other precommit
builds causing other contributors and reviewers to have to triage the test
failures to make sure they are not related. The whole point of having
automated unit tests is to help know if a change is safe. If for some reason a
change just _has_ to go in before the problems with the tests can be properly
fixed then we might as well just disable the tests and file a followup JIRA to
fix them rather than let them fail and cause everyone to keep rehashing the
same test failures over and over.
My apologies if I misunderstood the intentions of that comment, but I'm a
strong -1 to any change that is known to trigger unit test failures.
> Common scheduler changes supporting scheduler-specific implementations
> ----------------------------------------------------------------------
>
> Key: YARN-4511
> URL: https://issues.apache.org/jira/browse/YARN-4511
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Wangda Tan
> Assignee: Haibo Chen
> Attachments: YARN-4511-YARN-1011.00.patch,
> YARN-4511-YARN-1011.01.patch, YARN-4511-YARN-1011.02.patch,
> YARN-4511-YARN-1011.03.patch, YARN-4511-YARN-1011.04.patch,
> YARN-4511-YARN-1011.05.patch, YARN-4511-YARN-1011.06.patch,
> YARN-4511-YARN-1011.07.patch, YARN-4511-YARN-1011.08.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
