[ 
https://issues.apache.org/jira/browse/YARN-6927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217538#comment-16217538
 ] 

Daniel Templeton commented on YARN-6927:
----------------------------------------

Thanks for updating the patch.  I think we're now just down to a few minor 
details.

# Looks like you're still importing {{Optional}} in a couple of files.
# In {{YARNRunner}}, I think it would be better to call 
{{StringUtils.isEmpty()}} than doing the static import. I don't feel strongly 
about it, though.
# You have a few lines that are over the 80-char limit.

> Add support for individual resource types requests in MapReduce
> ---------------------------------------------------------------
>
>                 Key: YARN-6927
>                 URL: https://issues.apache.org/jira/browse/YARN-6927
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Daniel Templeton
>            Assignee: Gergo Repas
>         Attachments: YARN-6927.000.patch, YARN-6927.001.patch, 
> YARN-6927.002.patch, YARN-6927.003.patch, YARN-6927.004.patch
>
>
> YARN-6504 adds support for resource profiles in MapReduce jobs, but resource 
> profiles don't give users much flexibility in their resource requests.  To 
> satisfy users' needs, MapReduce should also allow users to specify arbitrary 
> resource requests.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to