[
https://issues.apache.org/jira/browse/YARN-6927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220799#comment-16220799
]
Daniel Templeton commented on YARN-6927:
----------------------------------------
One last comment, and I think we're done. Adding the debug logging is a clever
way to make checkstyle leave you alone, but those log messages aren't actually
helpful. I think it would be better to restructure the _if_. Instead of:{code}
} else if (MEM) {
LOG.debug(...);
} else if (CPU) {
LOG.debug(...);
} else {
...
}
{code} it would be clearer to do:{code}
} else if (!MEM && !CPU) {
...
}
{code} You could put your comments about why you're not processing mem and CPU
both combined inside that _else if_.
> Add support for individual resource types requests in MapReduce
> ---------------------------------------------------------------
>
> Key: YARN-6927
> URL: https://issues.apache.org/jira/browse/YARN-6927
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Daniel Templeton
> Assignee: Gergo Repas
> Attachments: YARN-6927.000.patch, YARN-6927.001.patch,
> YARN-6927.002.patch, YARN-6927.003.patch, YARN-6927.004.patch,
> YARN-6927.005.patch, YARN-6927.006.patch
>
>
> YARN-6504 adds support for resource profiles in MapReduce jobs, but resource
> profiles don't give users much flexibility in their resource requests. To
> satisfy users' needs, MapReduce should also allow users to specify arbitrary
> resource requests.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
