[
https://issues.apache.org/jira/browse/YARN-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16240596#comment-16240596
]
Konstantinos Karanasos commented on YARN-7437:
----------------------------------------------
bq. I'm fine with CandidateNodeSet/NodeSet, I would prefer CandidateNodeSet
over NodeSet.
I think {{CandidateNodeSet}} is good.
bq. I would prefer to have AppXYZPlacement, such as AppLocalityPlacement. I'm
fine with your points of removing Strategy from class name. And
AppSchedulingXYZ sounds too similar to AppSchedulingInfo, that's way I don't
prefer it.
We can call the superclass {{AppPlacement}} and the subclass
{{LocalityAppPlacement}}. I am wondering if {{AppPlacement}} is too generic. I
will ping Arun/Subru to see if they have any preference. But in any case,
something along these lines is fine.
Re: the offtopic, yep, that's more or less what I had in mind. As you say, it
is not of high priority at the moment -- it was just sharing a thought since it
came to mind and it seemed quite interesting :)
> Give SchedulingPlacementSet to a better name.
> ---------------------------------------------
>
> Key: YARN-7437
> URL: https://issues.apache.org/jira/browse/YARN-7437
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Wangda Tan
> Assignee: Wangda Tan
>
> Currently, the SchedulingPlacementSet is very confusing. Here're its
> responsibilities:
> 1) Store ResourceRequests. (Or SchedulingRequest after YARN-6592).
> 2) Decide order of nodes to allocate when there're multiple node candidates.
> 3) Decide if we should reject node for given requests.
> 4) Store any states/cache can help make decision for #2/#3
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
