[
https://issues.apache.org/jira/browse/YARN-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243047#comment-16243047
]
Konstantinos Karanasos commented on YARN-7437:
----------------------------------------------
Thanks for the patch, [~leftnoteasy]. Looks good, only some minor comments:
* AppPlacementAllocator: comments need some fixing -- remove double or etc.,
mention that we currently have a single node in the candidate set. There are
some TODOs left with your name, we should remove the name. Do you think we
should file JIRAs for those TODOs?
* CandidateNodeSet: let's add some more comments in the beginning of the class.
Also worth mentioning we currently consider a single node.
* CSQueue: {{@param ps @link PlacementSet of nodes which resources are
available}} -- let's make this a bit more precise (e.g., "the nodes that are
considered for the current placement).
* There are a few checkstyle issues that seem related to the patch.
* CapacityScheduler: {{candidates.getPartition()) >= 1.0f}} -- alignment looks
somehow off around those lines.
* I would prefer the variable candidates to be named something like
nodeCandidates in various classes, but that's not a big deal, I don't mind if
you leave it as is.
> Give SchedulingPlacementSet to a better name.
> ---------------------------------------------
>
> Key: YARN-7437
> URL: https://issues.apache.org/jira/browse/YARN-7437
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Wangda Tan
> Assignee: Wangda Tan
> Attachments: YARN-7437.001.patch, YARN-7437.002.patch,
> YARN-7437.003.patch
>
>
> Currently, the SchedulingPlacementSet is very confusing. Here're its
> responsibilities:
> 1) Store ResourceRequests. (Or SchedulingRequest after YARN-6592).
> 2) Decide order of nodes to allocate when there're multiple node candidates.
> 3) Decide if we should reject node for given requests.
> 4) Store any states/cache can help make decision for #2/#3
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
