[
https://issues.apache.org/jira/browse/YARN-6595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16241345#comment-16241345
]
Arun Suresh commented on YARN-6595:
-----------------------------------
Thanks for the review [~kkaranasos]
bq. Let's remove the test from the BasePBImplRecordsTest. I think we can add a
simple test at the TestAMRMClient.
Unfortunately, we need this - Since it is an inner component / sub field of
SchedulingRequest and AllocateRequest, the TestPBImplRecords will fail for all
these classes if we don't include the if-clause in the BasePBImplRecordsTest
(the reason being, PlacementConstraint is the only structure that deviates from
having a correspondingly named PBImpl class). I agree we can move the actual
testing of the PlacemetConstraint to another class - but we need this here
atleast for the interim.
I agree with the rest of your comments and shall address them shortly.
> [API] Add Placement Constraints at the application level
> --------------------------------------------------------
>
> Key: YARN-6595
> URL: https://issues.apache.org/jira/browse/YARN-6595
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Konstantinos Karanasos
> Assignee: Arun Suresh
> Attachments: YARN-6595-YARN-6592.001.patch,
> YARN-6595-YARN-6592.002.patch, YARN-6595-YARN-6592.003.patch,
> YARN-6595-YARN-6592.004.patch
>
>
> This JIRA allows placement constraints to be specified at the application
> level.
> This will be used for placement constraints between different components of
> the application.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
