[
https://issues.apache.org/jira/browse/YARN-6124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254564#comment-16254564
]
Zian Chen commented on YARN-6124:
---------------------------------
[~leftnoteasy]
I think I found the root cause for the bug in the YARN-6124.wip2.patch, the
issue is when calling the serviceInit in CapacityScheduler, we need to load the
config inside initScheduler before we init SchedulingMonitorManager, however
the current logic in wip2.patch is initing SchedulingMonitorManager inside
AbstractYarnSchedule's serviceInit which invoked before initScheduler been
called, which leads to config not been loaded when SchedulingMonitorManager
was initialized, then the monitor_interval was undefined. So my suggested
change is move the initialization of SchedulingMonitorManager from
AbstractYarnSchedule to CapacityScheduler, the same thing for FairScheduler.
According to my local Unit test and cluster testing, the modified patch can
enable/disable preemption by changing xml and refresh queue without restart RM.
> Make SchedulingEditPolicy can be enabled / disabled / updated with RMAdmin
> -refreshQueues
> -----------------------------------------------------------------------------------------
>
> Key: YARN-6124
> URL: https://issues.apache.org/jira/browse/YARN-6124
> Project: Hadoop YARN
> Issue Type: Task
> Reporter: Wangda Tan
> Assignee: Zian Chen
> Attachments: YARN-6124.wip.1.patch, YARN-6124.wip.2.patch
>
>
> Now enabled / disable / update SchedulingEditPolicy config requires restart
> RM. This is inconvenient when admin wants to make changes to
> SchedulingEditPolicies.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
