[
https://issues.apache.org/jira/browse/YARN-6124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16259540#comment-16259540
]
Eric Payne commented on YARN-6124:
----------------------------------
Thanks [~Zian Chen]. I appreciate the good work here. sorry for the late reply.
I have a couple of comments.
- {{AdminService#refreshQueues}}, first comment:
{code}
// We use getConfig() before which gets a capacity-scheduler.xml reference
// when parsing it into CapacityScheduler#reinitialize, but we need to get
// properties from yarn-site.xml when we want to enable/disable preemption
{code}
-- I wouldn't say anything about what it did before or about the capacity
scheduler, since this calls into all of the schedulers. Also, I wouldn't
specify preemption properties since the scheduling monitor can be pluggable and
doesen't have to be for preemption. I would just say something like this: {{//
Retrieve yarn-site.xml in order to refresh scheduling monitor properties.}}
- {{AdminService#refreshQueues}}, {{conf.size()}}:
-- Comment says {{force the Configuration#getProps been called to reload all
the properties.}}. I'm not sure why this is needed. I'm pretty sure that when
{{SchedulingMonitorManager#updateSchedulingMonitors}} calls the following code,
it will also call {{Configuration#getProps}} at that point:
{code}
boolean monitorsEnabled = conf.getBoolean(
YarnConfiguration.RM_SCHEDULER_ENABLE_MONITORS,
YarnConfiguration.DEFAULT_RM_SCHEDULER_ENABLE_MONITORS);
{code}
> Make SchedulingEditPolicy can be enabled / disabled / updated with RMAdmin
> -refreshQueues
> -----------------------------------------------------------------------------------------
>
> Key: YARN-6124
> URL: https://issues.apache.org/jira/browse/YARN-6124
> Project: Hadoop YARN
> Issue Type: Task
> Reporter: Wangda Tan
> Assignee: Zian Chen
> Attachments: YARN-6124.wip.1.patch, YARN-6124.wip.2.patch,
> YARN-6124.wip.3.patch
>
>
> Now enabled / disable / update SchedulingEditPolicy config requires restart
> RM. This is inconvenient when admin wants to make changes to
> SchedulingEditPolicies.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
