[ 
https://issues.apache.org/jira/browse/YARN-7242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16280870#comment-16280870
 ] 

Wangda Tan commented on YARN-7242:
----------------------------------

[~GergelyNovak], 

YARN-5881 will be merged to trunk tonight (PDT) if everything goes well. I 
still suggest using the same utility since it supports things like units, etc. 
I agree with you that we should put the functionality to ResourceUtils, and 
make improvements if possible. Could you wait another day before updating the 
patch?

In addition to that, we need to do two things to properly load resource types 
from server:

1) In Client, set YarnConfiguration#YARN_CLIENT_LOAD_RESOURCETYPES_FROM_SERVER 
to true while creating YarnClient. (And make sure this is done before 
instancing any Resource object.)
2) In ApplicationMaster, after receive RegisterApplicationMasterResponse from 
RM, it should call 
ResourceUtils#reinitializeResources(RegisterApplicationMasterResponse.getResourceTypes)
 before creating any Resource object. 

Please let me know if there's anything doesn't clear to you.

Thanks,
Wangda

> Support specify values of different resource types in DistributedShell for 
> easier testing
> -----------------------------------------------------------------------------------------
>
>                 Key: YARN-7242
>                 URL: https://issues.apache.org/jira/browse/YARN-7242
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Gergely Novák
>            Priority: Critical
>              Labels: newbie
>         Attachments: YARN-7242.001.patch, YARN-7242.002.patch
>
>
> Currently, DS supports specify resource profile, it's better to allow user to 
> directly specify resource keys/values from command line.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to