[ 
https://issues.apache.org/jira/browse/YARN-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16288644#comment-16288644
 ] 

Wangda Tan commented on YARN-7612:
----------------------------------

Thanks [~asuresh]. 

The latest patch looks much better. 

I haven't checked any details yet, quick comments about organizations of code 
packages.

Here's my proposal:

{code}
constraint/ 
        api/ (btw what is spi? is it a typo?):
                Algorithm
                SchedulingProposalCollector
                SchedulingRequestHandler
                SchedulingResponseHandler
                PlacementAlgorithmOutput
                PlacedSchedulingRequest
                SchedulingResponse
        
        impl/
                PlacementDispatcher
                PlacementProcessor
                SamplePlacementAlgorithm
                
                algorithms/sample/:
                        BatchedRequests
                        SamplePlacementAlgorithm
                        NodeCandidateSelector

        <rest things like>:
                PlacementConstraintsManager
                PlacementConstraintsManagerImpl
                AllocationTagsManager
                AllocationTagsNamespaces
                InvalidAllocationTagsQueryException
{code}

In addition, do you think we should move api and impl packages to 
{{scheduler.constraint}}? To me it is part of scheduler instead of being part 
of "placement". Same for reservation as well.

> Add Placement Processor and planner framework
> ---------------------------------------------
>
>                 Key: YARN-7612
>                 URL: https://issues.apache.org/jira/browse/YARN-7612
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Arun Suresh
>            Assignee: Arun Suresh
>         Attachments: YARN-7612-YARN-6592.001.patch, 
> YARN-7612-YARN-6592.002.patch, YARN-7612-YARN-6592.003.patch, 
> YARN-7612-YARN-6592.004.patch, YARN-7612-YARN-6592.005.patch, 
> YARN-7612-v2.wip.patch, YARN-7612.wip.patch
>
>
> This introduces a Placement Processor and a Planning algorithm framework to 
> handle placement constraints and scheduling requests from an app and places 
> them on nodes.
> The actual planning algorithm(s) will be handled in a YARN-7613.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to