[
https://issues.apache.org/jira/browse/YARN-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16290277#comment-16290277
]
Wangda Tan commented on YARN-7612:
----------------------------------
Thanks [~asuresh] for updating the patch.
Didn't get a chance to review many details of the patch. Comments from a
glance:
1. RejectionReason, ASF license should be the header of the file.
2. YarnConfiguration:
- placement-constraints.enabled is it necessary? Should we just read
placement.algorithm.class == null?
- placement.retry.attempts should we have a retry-policy? which should be
implemented by SchedulingResponseHandler.
3.
RMContainer#isConstrainedAllocation is added because we don't add request to
the scheduler. I understand there're some gaps now in adding SchedulingRequest
to AppSchedulingInfo.
I just attached a very early POC to:
https://issues.apache.org/jira/secure/attachment/12901991/YARN-6599.poc.001.patch
Do you think should we remove the isConstrainedAllocation logics once YARN-6599
get in? (Assume this patch goes in first)
4. ResourceScheduler#tryAllocate, should we replace schedulingRequest by
SchedulerRequestKey? Otherwise, we have to pass SchedulingRequest around and
downstream modules could modify it by accident.
5. Changes of RMAppImpl.java.
It looks like the change doesn't belong to the patch? Could you double check?
6. Could u add more explanations to new added APIs/classes? Otherwise, it will
be hard for other people to review.
Since I will on vacation until the beginning of Jan, I don't want to hold the
patch for such a long time. Instead, I would like other people to take a closer
look. I suggest waiting by end of next week before committing the patch.
Because the size of the patch is big and new logics are not trivial, it's
better to get it to a good state instead of reviewing it before merge.
> Add Placement Processor and planner framework
> ---------------------------------------------
>
> Key: YARN-7612
> URL: https://issues.apache.org/jira/browse/YARN-7612
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Arun Suresh
> Assignee: Arun Suresh
> Attachments: YARN-7612-YARN-6592.001.patch,
> YARN-7612-YARN-6592.002.patch, YARN-7612-YARN-6592.003.patch,
> YARN-7612-YARN-6592.004.patch, YARN-7612-YARN-6592.005.patch,
> YARN-7612-YARN-6592.006.patch, YARN-7612-v2.wip.patch, YARN-7612.wip.patch
>
>
> This introduces a Placement Processor and a Planning algorithm framework to
> handle placement constraints and scheduling requests from an app and places
> them on nodes.
> The actual planning algorithm(s) will be handled in a YARN-7613.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
