[ 
https://issues.apache.org/jira/browse/YARN-7688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305951#comment-16305951
 ] 

BELUGA BEHR commented on YARN-7688:
-----------------------------------

[[email protected]] Thanks for the feedback!  I have taken care of 
points #1 and #3.  For #2, I moved those lines around to match the ordering 
from several other methods that do the same thing.  I was just trying to keep 
it consistent across the methods.  New patch submitted.

> Miscellaneous Improvements To ProcfsBasedProcessTree
> ----------------------------------------------------
>
>                 Key: YARN-7688
>                 URL: https://issues.apache.org/jira/browse/YARN-7688
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: nodemanager
>    Affects Versions: 3.0.0
>            Reporter: BELUGA BEHR
>            Priority: Minor
>         Attachments: YARN-7688.1.patch, YARN-7688.2.patch
>
>
> * Use ArrayDeque for performance instead of LinkedList
> * Use more Apache Commons routines to replace existing implementations
> * Remove superfluous code guards around DEBUG statements
> * Remove superfluous annotations in the tests
> * Other small improvements



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to