[
https://issues.apache.org/jira/browse/YARN-7688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16306905#comment-16306905
]
BELUGA BEHR commented on YARN-7688:
-----------------------------------
[[email protected]] Attached a new patch
# Fixed check-style
# I think using the constant value for the "equals" check is always preferable.
It is impossible to hit a NullPointerException in this order. I made no
changes in this patch.
# The only change I made with the LOG statement is to remove the explicit
"toString()" method. The logger will call that for us. I made no changes in
this patch. For what you proposed, it would need to be:
{code}
LOG.info("ProcessTree: {}", p);
{code}
Dropping the toString was picky enough, for a unit test. Ha.
> Miscellaneous Improvements To ProcfsBasedProcessTree
> ----------------------------------------------------
>
> Key: YARN-7688
> URL: https://issues.apache.org/jira/browse/YARN-7688
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 3.0.0
> Reporter: BELUGA BEHR
> Priority: Minor
> Attachments: YARN-7688.1.patch, YARN-7688.2.patch, YARN-7688.3.patch,
> YARN-7688.4.patch
>
>
> * Use ArrayDeque for performance instead of LinkedList
> * Use more Apache Commons routines to replace existing implementations
> * Remove superfluous code guards around DEBUG statements
> * Remove superfluous annotations in the tests
> * Other small improvements
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
