[
https://issues.apache.org/jira/browse/YARN-7757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331740#comment-16331740
]
Naganarasimha G R commented on YARN-7757:
-----------------------------------------
Thanks Weiwei Yang for working on the patch and the approach. before deep
diving into the code i want to think out loud here. i have basic question that
do we require set of parallel classes for doing the same job (based on script
or configurations to pick up the labels and attributes ?). IMO we need to
incorporate the same classes to fetch the additional details for attributes too.
Unless we want labels to be fetched from the config and attributes from scripts
we would not require it to have parallel implementations. And i do not foresee
a need for it to be a separate implementations.
Further we can see how to work out the api changes and if require we can have
additional there but as part of user interaction i feel we can incorporate with
the modifications in the existing classes it self.
> Refactor NodeLabelsProvider to be more generic and reusable for node
> attributes providers
> -----------------------------------------------------------------------------------------
>
> Key: YARN-7757
> URL: https://issues.apache.org/jira/browse/YARN-7757
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Reporter: Weiwei Yang
> Assignee: Weiwei Yang
> Priority: Major
> Attachments: YARN-7757-YARN-3409.001.patch,
> YARN-7757-YARN-3409.002.patch, nodeLabelsProvider_refactor_class_hierarchy.pdf
>
>
> Propose to do refactor on {{NodeLabelsProvider}},
> {{AbstractNodeLabelsProvider}} to be more generic, so node attributes
> providers can reuse these interface/abstract classes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
