[
https://issues.apache.org/jira/browse/YARN-7757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331752#comment-16331752
]
Weiwei Yang commented on YARN-7757:
-----------------------------------
Hi [~Naganarasimha]
Thanks for taking time looking into this. Like I commented in [^Distributed
node attributes v1.pdf], and this comment. I was proposing to get
node-attributes fully distributed. So I was suggesting to let NM be able to
manage its own attributes, via
# A script provider
# Admin interface
So NM needs to gets the attributes from 2 providers and merge them then send
to RM. That was why the patch allows parallel providers. The refactor works
also fine if there is only 1 provider configured for the NM attribute manager,
that's the 1st step we are going to accomplish.
{quote}IMO we need to incorporate the same classes to fetch the additional
details for attributes too.
{quote}
The refactor in the patch was trying to make PROVIDER interface more general,
as having a DESCRIPTOR concept, it's easy to extend labels and attributes with
existing code base. It's odd to use same classes for attributes to me, that's
why I proposed this refactor.
> Refactor NodeLabelsProvider to be more generic and reusable for node
> attributes providers
> -----------------------------------------------------------------------------------------
>
> Key: YARN-7757
> URL: https://issues.apache.org/jira/browse/YARN-7757
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Reporter: Weiwei Yang
> Assignee: Weiwei Yang
> Priority: Major
> Attachments: YARN-7757-YARN-3409.001.patch,
> YARN-7757-YARN-3409.002.patch, nodeLabelsProvider_refactor_class_hierarchy.pdf
>
>
> Propose to do refactor on {{NodeLabelsProvider}},
> {{AbstractNodeLabelsProvider}} to be more generic, so node attributes
> providers can reuse these interface/abstract classes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
