[ 
https://issues.apache.org/jira/browse/YARN-7781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16341700#comment-16341700
 ] 

Gour Saha commented on YARN-7781:
---------------------------------

Thanks [~jianhe] for the patch. Quick comments -

1. In YarnServiceAPI.md:
Seems like "|false|string||" moved to a new line instead of being on the same 
line for "principal_name".

2. Fix the 2 whitespace errors.

3. In YARN-Services-Examples.md in the below section, is the "name" attribute 
with value "hello" required? The URI path already says that it is for the 
component name hello. So we should not need anything other than 
"number_of_containers" in the body.
{noformat}
### Update to flex up/down the number of containers (instances) of a component 
of a service
PUT URL - http://localhost:8088/app/v1/services/hello-world/components/hello
##### PUT Request JSON
```json
{
    "name": "hello",
    "number_of_containers": 3
}
{noformat}
4. Don't we support a PUT URL – 
[http://localhost:8088/app/v1/services/hello-world] where we can pass a single 
JSON and flex multiple components in a single API call? This is what I 
mentioned in point 1 in this jira description.

> Update YARN-Services-Examples.md to be in sync with the latest code
> -------------------------------------------------------------------
>
>                 Key: YARN-7781
>                 URL: https://issues.apache.org/jira/browse/YARN-7781
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Gour Saha
>            Assignee: Jian He
>            Priority: Major
>         Attachments: YARN-7781.01.patch
>
>
> Update YARN-Services-Examples.md to make the following additions/changes:
> 1. Add an additional URL and PUT Request JSON to support flex:
> Update to flex up/down the no of containers (instances) of a component of a 
> service
> PUT URL – http://localhost:9191/app/v1/services/hello-world
> PUT Request JSON
> {code}
> {
>   "components" : [ {
>     "name" : "hello",
>     "number_of_containers" : 3
>   } ]
> }
> {code}
> 2. Modify all occurrences of /ws/ to /app/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to