[ https://issues.apache.org/jira/browse/YARN-7757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346683#comment-16346683 ]
Sunil G commented on YARN-7757: ------------------------------- [~cheersyang] Thanks for the updated patch One quick doubt related to NodeScriptRunner. {code:java} 53 this.exec = new Shell.ShellCommandExecutor( 54 execScript.toArray(new String[execScript.size()]), null, null, 55 scriptTimeout);{code} Does this need to be run under some privileged mode or something similar ? As per current impl, this script will be run as NodeManager user. I am not sure whether any use case is there to run as privileged user to get some i/p (such as some system info) Could we give a bit more detailed comment in the script config section (such as yarn-default etc) to indicate the format of script o/p. This is for the easiness of in config. > Refactor NodeLabelsProvider to be more generic and reusable for node > attributes providers > ----------------------------------------------------------------------------------------- > > Key: YARN-7757 > URL: https://issues.apache.org/jira/browse/YARN-7757 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager > Reporter: Weiwei Yang > Assignee: Weiwei Yang > Priority: Blocker > Attachments: YARN-7757-YARN-3409.001.patch, > YARN-7757-YARN-3409.002.patch, YARN-7757-YARN-3409.003.patch, > YARN-7757-YARN-3409.004.patch, YARN-7757-YARN-3409.005.patch, > nodeLabelsProvider_refactor_class_hierarchy.pdf > > > Propose to do refactor on {{NodeLabelsProvider}}, > {{AbstractNodeLabelsProvider}} to be more generic, so node attributes > providers can reuse these interface/abstract classes. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org