[ 
https://issues.apache.org/jira/browse/YARN-7841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350170#comment-16350170
 ] 

Gergo Repas commented on YARN-7841:
-----------------------------------

+1 (non-binding)

Since this is a big piece of refactoring, I think a branch-2 version of the 
patch would be also good to have.

> Cleanup AllocationFileLoaderService's reloadAllocations method
> --------------------------------------------------------------
>
>                 Key: YARN-7841
>                 URL: https://issues.apache.org/jira/browse/YARN-7841
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: yarn
>    Affects Versions: 3.0.0
>            Reporter: Szilard Nemeth
>            Assignee: Szilard Nemeth
>            Priority: Minor
>         Attachments: YARN-7841-001.patch, YARN-7841-002.patch
>
>
> AllocationFileLoaderService's reloadAllocations method is too complex. 
> Please refactor / cleanup this method to be more simple to understand.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to