[
https://issues.apache.org/jira/browse/YARN-7841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352896#comment-16352896
]
Robert Kanter commented on YARN-7841:
-------------------------------------
Thanks for the patch [~snemeth] and the review [~grepas]. Overall looks good.
A few minor things:
- Some files are using {{*}} imports. We should change those to explicit
imports.
- No need to bother with the 80 character limit for import lines
- Take a look through the [checkstyle
warnings|https://builds.apache.org/job/PreCommit-YARN-Build/19512/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt].
There's some valid ones in here like line lengths and missing javadoc
comments.
> Cleanup AllocationFileLoaderService's reloadAllocations method
> --------------------------------------------------------------
>
> Key: YARN-7841
> URL: https://issues.apache.org/jira/browse/YARN-7841
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: yarn
> Affects Versions: 3.0.0
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Minor
> Attachments: YARN-7841-001.patch, YARN-7841-002.patch
>
>
> AllocationFileLoaderService's reloadAllocations method is too complex.
> Please refactor / cleanup this method to be more simple to understand.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
