[
https://issues.apache.org/jira/browse/YARN-7836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16357301#comment-16357301
]
Billie Rinaldi commented on YARN-7836:
--------------------------------------
bq. if the JSON body contains a name attribute with value anything other than
the <comp_name> in the path param, we should send a 400 bad request saying they
do not match. If they are the same, it should be okay and we can process the
request.
This is analogous to our update service endpoint. In that case, we're ignoring
the name in the Service spec and overwriting it with the service name from the
path param. But I could see doing it differently for the component name
(sending a bad request as you're suggesting), since there is no reason for the
component names not to match.
> YARN Service component update PUT API should not use component name from JSON
> body
> ----------------------------------------------------------------------------------
>
> Key: YARN-7836
> URL: https://issues.apache.org/jira/browse/YARN-7836
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: api, yarn-native-services
> Reporter: Gour Saha
> Assignee: Gour Saha
> Priority: Major
>
> The YARN Service PUT API for component update should not use component name
> from the JSON body. The component update PUT URI is as follows -
> [http://localhost:9191/app/v1/services/]<service_name>/components/<comp_name>
> e.g. [http://localhost:9191/app/v1/services/hello-world/components/hello]
> The component name is already in the URI, hence the JSON body expected should
> be only -
> {noformat}
> {
> "number_of_containers": 3
> }
> {noformat}
> It should not expect the name attribute in the JSON body. In fact, if the
> JSON body contains a name attribute with value anything other than the
> <comp_name> in the path param, we should send a 400 bad request saying they
> do not match. If they are the same, it should be okay and we can process the
> request.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
