[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362817#comment-16362817
]
Yufei Gu commented on YARN-5028:
--------------------------------
Thanks [~grepas]. Yes. We do need these two fields.
{code}
this.applicationACLsManager.addApplication(applicationId,
submissionContext.getAMContainerSpec().getApplicationACLs());
{code}
The code above in method {{createAndPopulateNewRMApp}} shows that
getAMContainerSpec() shouldn't be null, which leads to one question in the
patch:
{code}
if (srcCtx.getAMContainerSpec() != null) {
context.setAMContainerSpec(new ContainerLaunchContextPBImpl());
}
{code}
If srcCtx.getAMContainerSpec() is null, then context.getAMContainerSpec() is
null, which causes NPE. Another question is why use a new AMContainerSpec
instance for context instead of using the one of srcCtx?
> RMStateStore should trim down app state for completed applications
> ------------------------------------------------------------------
>
> Key: YARN-5028
> URL: https://issues.apache.org/jira/browse/YARN-5028
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: resourcemanager
> Affects Versions: 2.8.0
> Reporter: Karthik Kambatla
> Assignee: Gergo Repas
> Priority: Major
> Attachments: YARN-5028.000.patch, YARN-5028.001.patch,
> YARN-5028.002.patch
>
>
> RMStateStore stores enough information to recover applications in case of a
> restart. The store also retains this information for completed applications
> to serve their status to REST, WebUI, Java and CLI clients. We don't need all
> the information we store today to serve application status; for instance, we
> don't need the {{ApplicationSubmissionContext}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
