Yufei Gu commented on YARN-5028:

In case of {{createAndPopulateNewRMApp}}, it uses the ApplicationACLs in 
submission context, if you replace the original one with a new object. There is 
a risk to load wrong ACL. 

Nits in the unit test:
# The first set of assert seems unnecessary to me.
    assertEquals(appId, ctx.getApplicationId());
    assertEquals("a_queue", ctx.getQueue());
    assertEquals(17L, ctx.getResource().getMemorySize());
If you think it is necessary, please add some comments. 
#  For the second set, I think one assert should be enough. Something like this:
assertEquals("No prune if application state isn't FINISHED", 

Otherwise, looks good to me. 

> RMStateStore should trim down app state for completed applications
> ------------------------------------------------------------------
>                 Key: YARN-5028
>                 URL: https://issues.apache.org/jira/browse/YARN-5028
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: resourcemanager
>    Affects Versions: 2.8.0
>            Reporter: Karthik Kambatla
>            Assignee: Gergo Repas
>            Priority: Major
>         Attachments: YARN-5028.000.patch, YARN-5028.001.patch, 
> YARN-5028.002.patch
> RMStateStore stores enough information to recover applications in case of a 
> restart. The store also retains this information for completed applications 
> to serve their status to REST, WebUI, Java and CLI clients. We don't need all 
> the information we store today to serve application status; for instance, we 
> don't need the {{ApplicationSubmissionContext}}. 

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to