Arun Suresh commented on YARN-7920:

Thanks for working on this [~leftnoteasy]

Couple of comments:
* the {{ amsProcessingChain.init(rmContext, null);}} call should be in the 
{{initializeProcessingChain}} method.
* With regard to the {{SchedulerPlacementProcessor}}, we are assuming that if 
enabled, then placement constraints CANNOT be specified via the registerAM 
call.. Technically, you can still specify constraints in the register call - 
the schedulingRequest just overrides it.
* I agree with [~kkaranasos], we should make the value of the handler something 
the user should make sense of. Given that the major difference between the two 
approaches are the fact that the scheduler still handles for request in 
priority order and the processor tries to optimize for placement, ignoring 
priority, maybe we should call it "priority-optimized" and 
"placement-optimized" ? Thoughts ?

> Cleanup configuration of PlacementConstraints
> ---------------------------------------------
>                 Key: YARN-7920
>                 URL: https://issues.apache.org/jira/browse/YARN-7920
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>            Priority: Blocker
>         Attachments: YARN-7920.001.patch, YARN-7920.002.patch, 
> YARN-7920.003.patch
> Currently it is very confusing to have the two configs in two different files 
> (yarn-site.xml and capacity-scheduler.xml). 
> Maybe a better approach is: we can delete the scheduling-request.allowed in 
> CS, and update placement-constraints configs in yarn-site.xml a bit: 
> - Remove placement-constraints.enabled, and add a new 
> placement-constraints.handler, by default is none, and other acceptable 
> values are a. external-processor (since algorithm is too generic to me), b. 
> scheduler. 
> - And add a new PlacementProcessor just to pass SchedulingRequest to 
> scheduler without any modifications.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to