[
https://issues.apache.org/jira/browse/YARN-7707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366518#comment-16366518
]
Botong Huang commented on YARN-7707:
------------------------------------
Thanks [~youchen] for the patch. A few comments:
1. Please remove {{PolicyGeneratorService}} and schedule the runnable directly
in {{PolicyGenerator}}, similar to {{SubClusterCleaner}}
2. It is better to be able to disable {{PolicyGenerator}} from config. In fact,
let's make the default DEFAULT_GPG_POLICY_GENERATOR_INTERVAL_MS to be -1. When
the configured value is not positive, do not scheduler the service at all,
again similar to {{SubClusterCleaner}}.
3. Why do we need hadoop-yarn-server-timelineservice dependency in GPG's pom
file?
4. In {{PolicyGeneratorService.extractQueues()}}, we are extracting all (leaf
and non-leaf) queues. Do we need to generate policy for non-leaf queues? My
understanding is that no applications will be running in non-leaf queues.
> [GPG] Policy generator framework
> --------------------------------
>
> Key: YARN-7707
> URL: https://issues.apache.org/jira/browse/YARN-7707
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Carlo Curino
> Assignee: Young Chen
> Priority: Major
> Labels: federation, gpg
> Attachments: YARN-7707-YARN-7402.01.patch,
> YARN-7707-YARN-7402.02.patch, YARN-7707-YARN-7402.03.patch
>
>
> This JIRA tracks the development of a generic framework for querying
> sub-clusters for metrics, running policies, and updating them in the
> FederationStateStore.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
