[ 
https://issues.apache.org/jira/browse/YARN-7919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16367485#comment-16367485
 ] 

Haibo Chen commented on YARN-7919:
----------------------------------

Good catch, [~rohithsharma]! The jcodings problem is more of a dependency 
divergence  rather than a compilation issue, in my opinion. I greped its usage 
in hbase-client (2.0) module, here is what I found.
{code:java}
grep "org.jcodings.*" -R hbase-client
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/RegexStringComparator.java:30:import
 org.jcodings.Encoding;
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/RegexStringComparator.java:31:import
 org.jcodings.EncodingDB;
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/RegexStringComparator.java:32:import
 org.jcodings.specific.UTF8Encoding;
Binary file 
hbase-client/target/classes/org/apache/hadoop/hbase/filter/RegexStringComparator$JoniRegexEngine.class
 matches {code}
Looks like hbase-client relies on Jruby's joni regex engine to do pattern 
matching.  I am not sure if it is safe to just exclude jcondings to work around 
the dependency divergence problem.

Alternatively, we could either report to and ask HBase community so that they 
enforce the same version of jcodings in hbase-client, or override jcodings 
version explicitly in timelineservice modules. The override is only necessary 
in hbase 2.0, so the explicit dependency on jcodings is going to be in a maven 
profile. I think we should do both, do the override as a safe work around to 
unblock YARN-7346, but also file an HBase issue so that it can be properly 
addressed. Thoughts?

Will address your hbase-schema > hbase-common comment when we decide what to do 
with the jcondings issue.--

 

 

 

 

dfasfdas

> Split timelineservice-hbase module to make YARN-7346 easier
> -----------------------------------------------------------
>
>                 Key: YARN-7919
>                 URL: https://issues.apache.org/jira/browse/YARN-7919
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineservice
>    Affects Versions: 3.0.0
>            Reporter: Haibo Chen
>            Assignee: Haibo Chen
>            Priority: Major
>         Attachments: YARN-7919.00.patch, YARN-7919.01.patch, 
> YARN-7919.02.patch, YARN-7919.03.patch, YARN-7919.04.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to