[ 
https://issues.apache.org/jira/browse/YARN-7919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363552#comment-16363552
 ] 

Rohith Sharma K S commented on YARN-7919:
-----------------------------------------

thanks haibo for the patch! I verified the co-processor jar in cluster and it 
seems perfectly fine. 
# With current patch, I see below jars in timelineservice folder. 
## My view on this is lets NOT keep 
{color:red}hadoop-yarn-server-timelineservice-hbase-server-3.2.0-SNAPSHOT-coprocessor.jar{color}
 separately, rather we shall keep *co-processor* jar as 
{color:green}hadoop-yarn-server-timelineservice-hbase-server-3.2.0-SNAPSHOT.jar{color}
 itself that include common dependency as well since this jar is used in hbase 
server only. 
{code}
hadoop-yarn-server-timelineservice-3.2.0-SNAPSHOT.jar
hadoop-yarn-server-timelineservice-hbase-client-3.2.0-SNAPSHOT.jar
hadoop-yarn-server-timelineservice-hbase-common-3.2.0-SNAPSHOT.jar
hadoop-yarn-server-timelineservice-hbase-server-3.2.0-SNAPSHOT-coprocessor.jar
hadoop-yarn-server-timelineservice-hbase-server-3.2.0-SNAPSHOT.jar
lib
test
{code}
## After your current patch which generates jar with name co-processor, I was 
thinking about naming convention for co-processor jar. Should we name it as 
hadoop-yarn-server-timelineservice-hbase-coprocessor-3.2.0-SNAPSHOT.jar instead 
of hadoop-yarn-server-timelineservice-hbase-server-3.2.0-SNAPSHOT.jar?
# nit : I do see src folder in inside hadoop-yarn-server-timelineservice-hbase 
package structure. Is this only to me or others as well?
{code}
hadoop-yarn-server-timelineservice-hbase-client
hadoop-yarn-server-timelineservice-hbase-common
hadoop-yarn-server-timelineservice-hbase-server
hadoop-yarn-server-timelineservice-hbase.iml
pom.xml
src
target
{code}

> Split timelineservice-hbase module to make YARN-7346 easier
> -----------------------------------------------------------
>
>                 Key: YARN-7919
>                 URL: https://issues.apache.org/jira/browse/YARN-7919
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineservice
>    Affects Versions: 3.0.0
>            Reporter: Haibo Chen
>            Assignee: Haibo Chen
>            Priority: Major
>         Attachments: YARN-7919.00.patch, YARN-7919.01.patch, 
> YARN-7919.02.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to