[
https://issues.apache.org/jira/browse/YARN-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16381853#comment-16381853
]
Weiwei Yang commented on YARN-7988:
-----------------------------------
Hi [~bibinchundatt]
Thanks for the work on the refactoring, it helps a lot for code reuse. I can't
say I am fully qualified to review these code, I'll try to give some general
comments,
*NodeLabelsStore*
line 38, 44, 50, 63, 65: remove {{abstract}}
*FSNodeStoreLogOp*
It seems you map a sub class of {{FSNodeStoreLogOp}} to an enum
{{FSNodeLogOpCode}}, that seems to be just for class initializing, is this
required? Can it be replaced with simple factory method without reflection code?
*AbstractFSNodeStore*
# There seems to have chance to leak file descriptors, need to make sure close
is wrapped in finally clause, e.g AbstractFSNodeStore: line 126, line 160, line
177
# line 205, replace the deprecated cleanup method
*TestFileSystemNodeLabelsStore*
line 170: why the timeout is removed?
Hope it helps.
Thanks.
> Refactor FSNodeLabelStore code for attributes store support
> -----------------------------------------------------------
>
> Key: YARN-7988
> URL: https://issues.apache.org/jira/browse/YARN-7988
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Bibin A Chundatt
> Assignee: Bibin A Chundatt
> Priority: Major
> Attachments: YARN-7988.001.patch
>
>
> # Abstract out file FileSystemStore operation
> # Define EditLog Operartions and Mirror operation
> # Support compatibility with old nodelabel store
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
