[
https://issues.apache.org/jira/browse/YARN-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16382280#comment-16382280
]
Bibin A Chundatt commented on YARN-7988:
----------------------------------------
Thank you [~cheersyang] for review
{quote}
line 38, 44, 50, 63, 65: remove abstract
{quote}
done
{quote}
It seems you map a sub class of FSNodeStoreLogOp to an enum FSNodeLogOpCode,
that seems to be just for class initializing, is this required? Can it be
replaced with simple factory method without reflection code?
{quote}
In my opinion addition of new LogOp definition become easy within this case.
Any negative you find with approach?
{quote}
There seems to have chance to leak file descriptors, need to make sure close is
wrapped in finally clause, e.g AbstractFSNodeStore: line 126, line 160, line 177
{quote}
try-with-resource is used now.
{quote}
line 205, replace the deprecated cleanup method
{quote}
done
{quote}
TestFileSystemNodeLabelsStore
{quote}
During testcase debugging i did update timeout missed to revert the
same.Handled in latest patch.
> Refactor FSNodeLabelStore code for attributes store support
> -----------------------------------------------------------
>
> Key: YARN-7988
> URL: https://issues.apache.org/jira/browse/YARN-7988
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Bibin A Chundatt
> Assignee: Bibin A Chundatt
> Priority: Major
> Attachments: YARN-7988-YARN-3409.002.patch, YARN-7988.001.patch
>
>
> # Abstract out file FileSystemStore operation
> # Define EditLog Operartions and Mirror operation
> # Support compatibility with old nodelabel store
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
